Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deprecation warning about .avatar-stack #405

Merged
merged 1 commit into from Nov 15, 2017

Conversation

jonrohan
Copy link
Member

This pull adds a deprecation warning about .avatar-stack when primer-avatars is built the warning reads

".avatar-stack will be deprecated in version 11. Use .AvatarStack instead."

/cc @primer/ds-core

@broccolini
Copy link
Member

Thanks @jonrohan - let's test this with the combined 10.1.0 release in github/github cc @califa

@jonrohan
Copy link
Member Author

let's test this with the combined 10.1.0 release in github/github cc @califa

There's not much to see in github/github with this pr. But I can show you what the output looks like:

image

I have a PR for 10.1.0 in general https://github.com/github/github/pull/81613 that will have the avatars and everything else in this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants