Tooltipv2: Check if tooltip has popover attribute before opening or…

… closing the popover (#4463) * check if tooltip has popover attribute for open and close functions * Create dirty-pots-rule.md
primer · Apr 8, 2024 · 4b00129 · 4b00129
1 parent 3b72120
commit 4b00129
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/.changeset/dirty-pots-rule.md b/.changeset/dirty-pots-rule.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+TooltipV2: Check if tooltip element has `popover` attribute before calling `showPopover` and `hidePopover`
diff --git a/packages/react/src/TooltipV2/Tooltip.tsx b/packages/react/src/TooltipV2/Tooltip.tsx
@@ -196,7 +196,12 @@ export const Tooltip = React.forwardRef(
     const [calculatedDirection, setCalculatedDirection] = useState<TooltipDirection>(direction)
 
     const openTooltip = () => {
-      if (tooltipElRef.current && triggerRef.current && !tooltipElRef.current.matches(':popover-open')) {
+      if (
+        tooltipElRef.current &&
+        triggerRef.current &&
+        tooltipElRef.current.hasAttribute('popover') &&
+        !tooltipElRef.current.matches(':popover-open')
+      ) {
         const tooltip = tooltipElRef.current
         const trigger = triggerRef.current
         tooltip.showPopover()
@@ -216,7 +221,12 @@ export const Tooltip = React.forwardRef(
       }
     }
     const closeTooltip = () => {
-      if (tooltipElRef.current && triggerRef.current && tooltipElRef.current.matches(':popover-open')) {
+      if (
+        tooltipElRef.current &&
+        triggerRef.current &&
+        tooltipElRef.current.hasAttribute('popover') &&
+        tooltipElRef.current.matches(':popover-open')
+      ) {
         tooltipElRef.current.hidePopover()
       }
     }