correct types for markdown viewer label react 18 (#2408)

* correct types for markdown viewer label react 18 FC no longer has 'children' as implicit, so they must be defined separately * changeset Co-authored-by: Josh Black <joshblack@github.com>
primer · Oct 6, 2022 · c639acb · c639acb
1 parent 2e7a970
commit c639acb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.changeset/eleven-years-march.md b/.changeset/eleven-years-march.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+fix react 18 typing for MarkdownEditor.Label
diff --git a/src/drafts/MarkdownEditor/Label.tsx b/src/drafts/MarkdownEditor/Label.tsx
@@ -6,6 +6,7 @@ import {MarkdownEditorContext} from './_MarkdownEditorContext'
 
 type LabelProps = SxProp & {
   visuallyHidden?: boolean
+  children?: React.ReactNode
 }
 
 // ref is not forwarded because InputLabel does not (yet) support it