renderMenuItem in ActionMenu checks preventDefault onClose (#1214)

primer · May 12, 2021 · d78af59 · d78af59 · vercel · May 12, 2021
1 parent ff9ce6f
commit d78af59
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/silver-fans-jump.md b/.changeset/silver-fans-jump.md
@@ -0,0 +1,5 @@
+---
+"@primer/components": patch
+---
+
+renderMenuItem in ActionMenu checks preventDefault for conditionally calling onClose
diff --git a/src/ActionMenu.tsx b/src/ActionMenu.tsx
@@ -80,7 +80,9 @@ const ActionMenuBase = ({
           const actionCallback = itemOnAction ?? onAction
           pendingActionRef.current = () => actionCallback?.(props as ItemProps, event)
           actionCallback?.(props as ItemProps, event)
-          onClose()
+          if (!event.defaultPrevented) {
+            onClose()
+          }
         }
       })
     },