Skip to content

Commit

Permalink
fix(useDetails): update ref type (#2656)
Browse files Browse the repository at this point in the history
* fix(useDetails): update ref type

* chore: add changeset
  • Loading branch information
joshblack committed Dec 16, 2022
1 parent 20e18c0 commit db0db6e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/flat-feet-sing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Update useDetails `ref` type to HTMLDetailsElement
4 changes: 2 additions & 2 deletions src/hooks/useDetails.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {useCallback, useEffect, useState, useRef} from 'react'

type UseDetailsParameters = {
ref?: React.RefObject<HTMLElement>
ref?: React.RefObject<HTMLDetailsElement>
closeOnOutsideClick?: boolean
defaultOpen?: boolean
onClickOutside?: (event: MouseEvent) => void
Expand All @@ -16,7 +16,7 @@ function useDetails({ref, closeOnOutsideClick, defaultOpen, onClickOutside}: Use
(event: MouseEvent) => {
const {current} = customRef
const eventTarget = event.target as HTMLElement
const closest = eventTarget.closest('details') as HTMLDetailsElement
const closest = eventTarget.closest('details')
if (closest !== current) {
onClickOutside && onClickOutside(event)
if (!event.defaultPrevented) {
Expand Down

0 comments on commit db0db6e

Please sign in to comment.