Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointerBox needs to support sx props #1508

Closed
dusave opened this issue Oct 7, 2021 · 1 comment · Fixed by #1804
Closed

PointerBox needs to support sx props #1508

dusave opened this issue Oct 7, 2021 · 1 comment · Fixed by #1804
Labels
bug Something isn't working react size: sand

Comments

@dusave
Copy link
Contributor

dusave commented Oct 7, 2021

Describe the bug
PointerBox only allows use of bg, borderColor, etc. props to style it, but as advised, we are migrating to use sx instead. In this instance, it breaks the styling because sx props are not accounted for. Also, unless position: relative is supplied in the sx object, the Caret will render in the top left of the page as it blows away the local sx prop in the component, rather than doing a spread/object merge.

To Reproduce
Steps to reproduce the behavior:
Instantiate a PointerBox component using sx={{bg: '#ff0000'}} and notice that the background does not go red.

Expected behavior
It should either exclusively look for sx styling or use an either/or logic block to style the Caret

Screenshots
image

@rezrah
Copy link
Contributor

rezrah commented Jan 26, 2022

@dusave - Just a heads up that this issue was resolved and is shipping in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react size: sand
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants