Fixes PointerBox caret not styling correctly using sx props #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d191f82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
59 tasks
size-limit report 📦
|
pksjce
reviewed
Jan 18, 2022
| backgroundColor?: string | ||
| borderColor?: string | ||
| } | ||
| } & SxProp |
There was a problem hiding this comment.
wow i wonder if this can be removed?
There was a problem hiding this comment.
🤷♂️ any ideas? I can't seem to coerce the types to match with sx without doing this. Couldn't find any other similar patterns either, so stuck a FIXME on it for now to come back to later. Would appreciate any suggestions 🙏
colebemis
reviewed
Jan 24, 2022
colebemis
reviewed
Jan 24, 2022
…ret-not-styling-correctly
mperrotti
approved these changes
Jan 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some housekeeping to close down old issues 🧹
Closes #1508
Caret.BorderedBoxincluding broken documentation linkPointerBoxto new layout for consistencyScreenshots
Before:
After:
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.