Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavList.Group should pass all props through to the ActionList.Group #2132

Closed
mattcosta7 opened this issue Jun 20, 2022 · 0 comments · Fixed by #2133
Closed

NavList.Group should pass all props through to the ActionList.Group #2132

mattcosta7 opened this issue Jun 20, 2022 · 0 comments · Fixed by #2133
Labels

Comments

@mattcosta7
Copy link
Collaborator

mattcosta7 commented Jun 20, 2022

Describe the bug

const Group = ({title, children, sx: sxProp = {}}: NavListGroupProps) => {

(as a nit here - using sx = {} in the function definition means every render by default supplies a new sx object. sx = defaultSx, where previously const defaultSx = {} would avoid that

NavList.Group only accepts a handful of props from ActionList.Group, and should probably accept almost/all and pass them through, specifically for things like aria attributes and data props, for test ids, etc

Note: As this is a public repo, please be careful not to include details or screenshots from unreleased GitHub products or features. In most cases, a good bug report should be able to describe the new component without including business logic or feature details, but if you must discuss context relating to an unreleased feature, please open an issue in the private Design Systems repo and link to it here.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants