-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prop to describe color theme #26
Comments
I'm wondering if we can get away with What about even just |
Here's a bunch of thoughts I have on this.... Currently styled-system uses I think we should not use prop names that match utility props because that's confusing, and because often because we're applying a combination of colors. Not sure how I feel about this yet but styled-system uses We can customize props in styled-system and use Overall I prefer |
Agreed: |
We need to come up with a name for a prop that describes a color theme (background color + text color, etc)...
theme
could easily be mixed up with our themes (light/dark). MaybecolorPattern
?colorScheme
? maybetheme
is ok? thoughts?The text was updated successfully, but these errors were encountered: