Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get ActionBar axe clean #4387

Closed
keithamus opened this issue Mar 13, 2024 · 0 comments · Fixed by #4388
Closed

Get ActionBar axe clean #4387

keithamus opened this issue Mar 13, 2024 · 0 comments · Fixed by #4388
Assignees
@keithamus
Labels
bug Something isn't working react

Comments

@keithamus
Copy link
Member

Description

ActionBar is not axe clean. It renders a <ul> with <button>s as direct children. It has a role=list on the <ul> which would be unnecessary for a <ul>. It should be role=toolbar though.

Steps to reproduce

.

Version

Latest

Browser

No response
@keithamus keithamus added the bug Something isn't working label Mar 13, 2024
@keithamus keithamus mentioned this issue Mar 13, 2024
Merged
13 tasks
@keithamus keithamus assigned keithamus and unassigned keithamus Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithamus keithamus

Labels
bug Something isn't working react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

get ActionBar axe clean primer/react
1 participant
@keithamus