Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the donuts #99

Closed
shawnbot opened this issue Jun 29, 2018 · 1 comment
Closed

Clean up the donuts #99

shawnbot opened this issue Jun 29, 2018 · 1 comment
Assignees
@shawnbot
Projects
Primer Components release tracking 📋

Comments

@shawnbot
Copy link
Contributor

  1. This line is a mess: child.props.key doesn't exist, which results in un-keyed elements. Maybe calling React.cloneElement() would be better here?
  2. The DonutPropType bit is kind of silly. That PropTypes.shape() call can be wrapped in oneOrMoreOf() from props.js.
@shawnbot shawnbot self-assigned this Jun 29, 2018
@emplums emplums added this to v0.0.7-beta To Do in Primer Components release tracking 📋 Jul 2, 2018
@shawnbot shawnbot mentioned this issue Jul 2, 2018
Merged
@shawnbot shawnbot moved this from v0.0.7-beta To Do to 🙇‍♀️ WIP in Primer Components release tracking 📋 Jul 2, 2018
@shawnbot shawnbot moved this from 🙇‍♀️ WIP to v0.0.7-beta completed in Primer Components release tracking 📋 Jul 3, 2018
@emplums emplums mentioned this issue Jul 3, 2018
Merged
6 tasks
@emplums emplums moved this from v0.0.7-beta completed to 🚢Published in Primer Components release tracking 📋 Jul 9, 2018
@shawnbot
Copy link
Contributor Author

This was fixed in #103.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnbot shawnbot

Labels
None yet
Projects
No open projects
Primer Components release tracking 📋
  
🚢Published
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawnbot