Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix donuts #103

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Fix donuts #103

merged 3 commits into from
Jul 3, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Jul 2, 2018

A couple of things to fix #99:

  • Remove child.props.key reference, which doesn't work. Instead, call React.cloneElement() with a new d prop.
  • Remove explicit children prop type validation from DonutChart and DonutSlice, which Dan Abramov says is an anti-pattern 馃槵

@shawnbot shawnbot requested review from emplums and a team and removed request for emplums July 2, 2018 20:31
emplums
emplums approved these changes Jul 2, 2018
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 馃憤

@shawnbot shawnbot merged commit 996b03c into release-0.0.7-beta Jul 3, 2018
@shawnbot shawnbot deleted the fix-donuts branch July 3, 2018 03:32
@shawnbot shawnbot mentioned this pull request Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawnbot @emplums