Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SelectMenu to TypeScript #1048

Merged
merged 10 commits into from
Feb 19, 2021
Merged

Migrate SelectMenu to TypeScript #1048

merged 10 commits into from
Feb 19, 2021

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Feb 12, 2021

This PR migrates the SelectMenu component to TypeScript as part of the TypeScript refactor.

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2021

🦋 Changeset detected

Latest commit: 35d0d75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/ovrr2l253
✅ Preview: https://primer-components-git-cb-ts-select-menu.primer.vercel.app

@vercel vercel bot temporarily deployed to Preview February 12, 2021 20:19 Inactive
@colebemis colebemis mentioned this pull request Feb 12, 2021
53 tasks
@vercel vercel bot temporarily deployed to Preview February 12, 2021 20:22 Inactive
Copy link
Contributor

@VanAnderson VanAnderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big chunk of work here! It looks good to me, I'm definitely learning a bit as I look through it.

@vercel vercel bot temporarily deployed to Preview February 19, 2021 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview February 19, 2021 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview February 19, 2021 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview February 19, 2021 19:25 Inactive
@vercel vercel bot temporarily deployed to Preview February 19, 2021 19:34 Inactive
@colebemis colebemis merged commit 82b34ea into main Feb 19, 2021
@colebemis colebemis deleted the cb/ts-select-menu branch February 19, 2021 19:38
@github-actions github-actions bot mentioned this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants