Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement functional color variables 4 [ButtonDanger, ButtonOutline, ButtonPrimary, ButtonClose] #1100

Merged
merged 9 commits into from
Mar 4, 2021

Conversation

VanAnderson
Copy link
Contributor

This PR updates the following components to use functional color variables in preparation for color mode support:

  • ButtonDanger
  • ButtonOutline
  • ButtonPrimary
  • ButtonClose

Part of https://github.com/github/design-systems/issues/1219

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2021

🦋 Changeset detected

Latest commit: deaf900

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/HWxybr1WYWaE8ggTc7CiKxaRir9C
✅ Preview: https://primer-compone-git-vananderson-implement-functional-colo-8c9ec2.vercel.app

@VanAnderson VanAnderson force-pushed the VanAnderson/implement-functional-color-vars-4 branch from 1f36674 to 9259750 Compare March 2, 2021 20:26
@vercel vercel bot temporarily deployed to Preview March 2, 2021 20:26 Inactive
@VanAnderson VanAnderson changed the title Van anderson/implement functional color vars 4 Implement functional color variables 4 [ButtonDanger, ButtonOutline, ButtonPrimary, ButtonClose] Mar 2, 2021
@VanAnderson VanAnderson marked this pull request as ready for review March 2, 2021 20:27
Copy link

@bscofield bscofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vercel vercel bot temporarily deployed to Preview March 3, 2021 22:25 Inactive
src/Button/ButtonOutline.tsx Outdated Show resolved Hide resolved
src/Button/ButtonOutline.tsx Outdated Show resolved Hide resolved
src/Button/ButtonOutline.tsx Outdated Show resolved Hide resolved
src/Button/ButtonOutline.tsx Outdated Show resolved Hide resolved
src/Button/ButtonPrimary.tsx Outdated Show resolved Hide resolved
src/Button/ButtonPrimary.tsx Outdated Show resolved Hide resolved
src/Button/ButtonClose.tsx Outdated Show resolved Hide resolved
src/Button/ButtonClose.tsx Show resolved Hide resolved
src/Button/ButtonClose.tsx Outdated Show resolved Hide resolved
src/Button/ButtonClose.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview March 4, 2021 07:28 Inactive
src/Button/ButtonOutline.tsx Outdated Show resolved Hide resolved
src/Button/ButtonDanger.tsx Outdated Show resolved Hide resolved
src/Button/ButtonDanger.tsx Outdated Show resolved Hide resolved
src/Button/ButtonDanger.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview March 4, 2021 07:36 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks like you just need to update the snapshots and this should be ready to merge 🚢

@vercel vercel bot temporarily deployed to Preview March 4, 2021 15:52 Inactive
@VanAnderson VanAnderson force-pushed the VanAnderson/implement-functional-color-vars-4 branch from 3c50615 to 4d9bff6 Compare March 4, 2021 15:52
@vercel vercel bot temporarily deployed to Preview March 4, 2021 15:55 Inactive
@vercel vercel bot temporarily deployed to Preview March 4, 2021 16:22 Inactive
@colebemis colebemis merged commit 6c7ec7a into main Mar 4, 2021
@colebemis colebemis deleted the VanAnderson/implement-functional-color-vars-4 branch March 4, 2021 16:26
@github-actions github-actions bot mentioned this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants