Pass aria-label down to correct element #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 44aa68e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/7FzqSK1yiUBxXx2pC7q3YDx4kUJ7 |
emplums
commented
Mar 2, 2021
| @@ -1,6 +1,6 @@ | |||
| import React from 'react' | |||
| import {TabNav} from '..' | |||
| import {mount, render, rendersClass, behavesAsComponent, checkExports} from '../utils/testing' | |||
There was a problem hiding this comment.
These weren't being used anywhere
smockle
approved these changes
Mar 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR patches a bug introduced in my last TabNav PR. I refactored the components so that the
navcomponent is the inner component (as it should be & to match implementation in .com), but I forgot to forwardaria-labeldown to thenavwhich was throwing axe errors in Memex.This PR fixes that and updates the tests to be more specific, making sure the aria-label gets applied to the
navand not the wrapping element ☮️Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
index.d.ts) if necessaryTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.