Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic docs for AnchoredOverlay #1192

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Add basic docs for AnchoredOverlay #1192

merged 2 commits into from
Apr 29, 2021

Conversation

dgreif
Copy link
Member

@dgreif dgreif commented Apr 29, 2021

Adding minimal docs for AnchoredOverlay since that's the new baseline for alpha components. I also figured out how view_components was presenting component status and replicated that here.

Screenshots

image

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@dgreif dgreif requested a review from bscofield April 29, 2021 18:49
@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2021

🦋 Changeset detected

Latest commit: e5a4a8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/DofSiGuSCzxGYXdDYV5MqXnd1STE
✅ Preview: https://primer-components-git-anchored-overlay-docs-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview April 29, 2021 18:49 Inactive
Copy link

@bscofield bscofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this still needs a changeset, but otherwise I'm 👍

@vercel vercel bot temporarily deployed to Preview April 29, 2021 19:05 Inactive
@dgreif dgreif merged commit 17957f2 into main Apr 29, 2021
@dgreif dgreif deleted the anchored-overlay-docs branch April 29, 2021 19:09
@github-actions github-actions bot mentioned this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants