Perform ActionMenu actions after overlay has closed #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16c170a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/v1i5SCCjnqVtCwAboB69GhTndqtn |
dgreif
force-pushed
the
action-after-close
branch
from
7428e9a
to
2fa3918
Compare
smockle
reviewed
Apr 30, 2021
VanAnderson
approved these changes
Apr 30, 2021
This was referenced Apr 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate approach to solve the problems addressed by #1188. When an action is selected from the menu, we want to wait until the menu has closed the overlay before performing the action. This is important in situations where the action moves focus to a different element on the page. Without this change, the focus change from the action would be detected by the overlay focus trap, preventing focus from actually shifting to the intended target. While #1188 did present two valid ways of solving this problem, @T-Hugs and @smockle agreed that the approach in this PR is a simpler solution for the immediate issue.
Closes #1188
Screenshots
Merge checklist