ActionList Fixes #1215
Merged
ActionList Fixes #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d604c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/AwfrL2RE61W7UMpqyhpBnACmCd7L |
colebemis
reviewed
May 12, 2021
.changeset/blue-items-repeat.md
Outdated
| Hide divider before `ActionList.Group`s with filled header | ||
| Align `Item` description to when rendered in-line | ||
| Add `selectionVariant: 'multiple'` for `Item`s. These will use a checkbox input instead of a checkmark icon for selected state | ||
| Allow `focusZoneSettings` to be passed into `AnchoredOverlay` |
There was a problem hiding this comment.
If it's not too much trouble, it might be nice to put all these distinct changes in their own changeset.
… 'Dialog', to avoid clipping focus ring outlines (particularly in Safari). Because this would collapse margins, add 'position: absolute' to 'ErsatzOverlay' to avoid collapsing 'List'’s top and bottom margins
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing a number of issues found when integrating
ActionListintoSelectPanelinlinedescription is not inlineWrap item in a(Using<label>?aria-label={text}to avoid branching DOM and for succinct announcements)Update docs with new(Prop is commented in theselectionVariantoptionItemPropsinterface definition, butActionList.Itemdoes not have a corresponding.mdxfile)Screenshots
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.