Anchored overlay can take an external AnchorRef #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9999c12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/4Sk7ocYfeawVWJqTnBw5dqwzncUv |
VanAnderson
force-pushed
the
VanAnderson/anchored-overlay-tweaks
branch
from
0fd5278
to
4bf2ea4
Compare
VanAnderson
force-pushed
the
VanAnderson/anchored-overlay-tweaks
branch
from
36b108f
to
1f3c2bc
Compare
dgreif
requested changes
Jun 3, 2021
Co-authored-by: Dusty Greif <dgreif@users.noreply.github.com>
VanAnderson
force-pushed
the
VanAnderson/anchored-overlay-tweaks
branch
from
4125232
to
c265aa6
Compare
smockle
approved these changes
Jun 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for more flexible relationships between anchor and overlay by allowing a user to supply their own external AnchorRef.