Fix TextInput prop types & remove system props #1414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should give us a more accurate type for the props of
TextInput
. Previously the props included:But that left some props as a messy intersection of types, like
onChange
(#1377). We can resolve that by explicitly omitting any fields from Input's props that are explicitly destructured from TextInput's props.Closes #1377
See also #1163
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.