Exclude storybook stories from TypeScript compilation for builds

[jfuchs]

In the course of investigating TypeScript type questions with @colebemis, we noticed that building our typedefs with any Storybook story included would lead to some components gaining a css prop in their typedef. E.g., lib/Button/Button.d.ts would include the line:

      css?: import("@emotion/core").InterpolationWithTheme<any>;

And excluding all stories would give us a build without any css props attached to components. This solution should give us clean type defs in our builds while still allowing typechecking of stories. Some caveats:

• There is a possibility that some errors will not be caught until running the build script, which isn't part of most people's workflow, from what I can tell. I suspect these will be rare.
• We still don't know why the optional property became required as it did in the linked bug.
• This bug might only have surfaced with the intersection of multiple factors, and we're removing only one. There might be some other patterns we should still clean up (wild speculation: incorrect typing around PRC components spreading "rest" props on subcomponents)

Closes #1163

Screenshots

😅

Merge checklist

• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 72be46e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	51.71 KB (0%)
dist/browser.umd.js	52 KB (0%)

[dgreif]

Nice fix!