Add focus and hover colors to all themes in Item using functional variables #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e1208d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
Notes -
|
|
Looks like
Let's loop in @tallys and @auareyou because I think this issue is going to require more design work than I initially thought. |
|
@pksjce - should we modify this PR now that primer/primitives#256 has merged? |
siddharthkp
reviewed
Nov 19, 2021
siddharthkp
reviewed
Nov 19, 2021
| @@ -418,8 +391,6 @@ export const Item = React.forwardRef((itemProps, ref) => { | |||
| data-id={id} | |||
| onKeyPress={keyPressHandler} | |||
| onClick={clickHandler} | |||
| hoverBackground={disabled ? 'inherit' : hoverBackground} | |||
siddharthkp
approved these changes
Nov 19, 2021
This was referenced Nov 22, 2021
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, hardcoded RGB colors were being used for the hover and focus states. I changed them to use the functional color system as described in #1480
Screenshots
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.