Component that renders a text input with tokens #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
colebemis
reviewed
Oct 4, 2021
colebemis
reviewed
Oct 4, 2021
Co-authored-by: Cole Bemis <colebemis@github.com>
🦋 Changeset detectedLatest commit: fde0b6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Removing tokens doesn't seem to be working for the label story:
|
colebemis
reviewed
Oct 4, 2021
colebemis
reviewed
Oct 4, 2021
colebemis
reviewed
Oct 4, 2021
| * Whether the remove buttons should be rendered in the tokens | ||
| */ | ||
| // TODO: confirm whether or not we're comfortable with allowing people to hide that button | ||
| hideTokenRemoveButtons?: boolean |
There was a problem hiding this comment.
If we keep this option, should we add some check to ensure that the tokenComponent has a hideRemoveButton prop?
colebemis
reviewed
Oct 4, 2021
colebemis
reviewed
Oct 4, 2021
…eLabelTokens, fixes IssueLabelToken import typo
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
colebemis
reviewed
Oct 12, 2021
colebemis
requested changes
Oct 12, 2021
There was a problem hiding this comment.
I think this is almost ready to go!
Just needs a changeset and a props table
Co-authored-by: Cole Bemis <colebemis@github.com>
…/text-input-with-tokens-component
…er/react into mp/text-input-with-tokens-component
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A component has been added that allows the Tokens from #1488 to be rendered inside of a text input.
Screenshots
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.