Updates ActionList's ItemInput type to accept DOM props for divs when renderItem is not provided #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a206456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
jfuchs
force-pushed
the
jfuchs/wider-item-type
branch
from
284d424
to
1440875
Compare
… renderItem is not provided
jfuchs
force-pushed
the
jfuchs/wider-item-type
branch
from
1440875
to
6634d29
Compare
smockle
approved these changes
Oct 5, 2021
| @@ -10,7 +10,9 @@ import {hasActiveDescendantAttribute} from '../behaviors/focusZone' | |||
|
|
|||
| type RenderItemFn = (props: ItemProps) => React.ReactElement | |||
|
|
|||
| export type ItemInput = ItemProps | ((Partial<ItemProps> & {renderItem: RenderItemFn}) & {key?: Key}) | |||
| export type ItemInput = | |||
There was a problem hiding this comment.
Since ActionList’s items type now diverges from ItemProps, does the props documentation for ActionList need to be updated?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR widens our
ActionListcomponent'sItemInputtype so that DOM props fordivare allowed. This is only a type change and should not change the function of the compiled code.This surfaced when @smockle was upgrading PRC in an internal project from v30.0.0 to v30.1.0, and noticed that that project's usage of PRC included passing
onMouseDownlisteners in theItemInputobjects. This PR restores correct typing for that usage.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.