Bump @primer/primitives to v5 #1514
Conversation
🦋 Changeset detectedLatest commit: a9245bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| @@ -55,7 +55,8 @@ | |||
| { | |||
| "allow": ["dark_dimmed"] | |||
| } | |||
| ] | |||
| ], | |||
| "primer-react/no-deprecated-colors": ["warn", {"checkAllStrings": true}] | |||
There was a problem hiding this comment.
I see! it was only on mdx files previously.
| @@ -44,7 +44,7 @@ | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@primer/octicons-react": "^13.0.0", | |||
| "@primer/primitives": "4.8.1", | |||
| "@primer/primitives": "5.1.0", | |||
| // TODO: choose a better functional color variable for this | ||
| background-color: ${get('colors.neutral.muted')}; | ||
| } | ||
|
|
||
| &:active { | ||
| background-color: ${get('colors.fade.fg15')}; | ||
| // TODO: choose a better functional color variable for this | ||
| background-color: ${get('colors.neutral.subtle')}; |
There was a problem hiding this comment.
@mperrotti Since fade.* variables were removed in Primitives v5, I had to make a best guess at alternative functional variables. Can you check out the preview storybook and see if you're okay with these alternatives?
There was a problem hiding this comment.
These work well for the regular tokens, but they're not ideal for IssueLabelTokens that have dark background colors.
There was a problem hiding this comment.
I'm comfortable going forward with this as-is and improving in a follow-up
There was a problem hiding this comment.
Agreed. @auareyou do you have any ideas about how we can replace fade variables here?
There was a problem hiding this comment.
I think neutral.subtle is the right move. For the IssueLabelToken one it seems neutral.muted works better because it darkens what is light and it lightens what is dark:
There was a problem hiding this comment.
Sweet. Let's move forward with this as-is for now 👍
Bumps @primer/primitives to v5 and addresses breaking changes in that release.