Fix: TextInput styling regression with icon and block prop usage #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ea076f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
reviewed
Nov 10, 2021
siddharthkp
reviewed
Nov 10, 2021
| ) | ||
| } | ||
|
|
||
| export const WithLeadingIcon = (args: TextInputProps) => { |
siddharthkp
approved these changes
Nov 10, 2021
colebemis
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
TextInputcomponent suffers from a visual regression when you use bothiconandblockprops together.This PR fixes the regression, while attempting to ensure that no further regressions are introduced.
Changes
TextInputScreenshots and 🎥
Before:
Screen.Recording.2021-11-10.at.13.59.38.mov
After:
Screen.Recording.2021-11-10.at.14.06.26.mov
New Storybook:
Screen.Recording.2021-11-10.at.14.07.46.mov
Reviewer notes
TextInputcomponent will undergoalpha=>betarefactoring shortly and the longer-term solution should perhaps, come from acssclassname instead (I'm unsure if it already exists)Merge checklist