Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionList: Add keyboard accessibility #1603

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Conversation

siddharthkp
Copy link
Member

Part of https://github.com/github/primer/issues/447
Includes visual changes for keyboard focus from https://github.com/github/primer/issues/409

Please provide before/after screenshots for any visual changes

before:

tab.tab.fail.mov

after:

tabtab.mov

Merge checklist

  • Added/updated tests
  • NA Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2021

🦋 Changeset detected

Latest commit: 5500790

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 54.44 KB (0%)
dist/browser.umd.js 54.83 KB (0%)

@siddharthkp siddharthkp self-assigned this Nov 11, 2021
@siddharthkp siddharthkp marked this pull request as ready for review November 12, 2021 10:24
@siddharthkp siddharthkp requested review from a team and pksjce November 12, 2021 10:24
@pksjce
Copy link
Collaborator

pksjce commented Nov 15, 2021

Hey not sure if this is valid. What does inset mean anyways?

Screen.Recording.2021-11-15.at.3.43.12.pm.mov

@siddharthkp
Copy link
Member Author

siddharthkp commented Nov 15, 2021

Hey not sure if this is valid

The last option? Not sure how to adapt focus styles if the user has given custom styles to an Item with sx 🤔 Ideas? (happy to tackle in another PR)

What does inset mean anyways?

inset children are offset (vertically and horizontally) from List’s edges, full children are flush (vertically and horizontally) with List edges.

Group 112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants