Input field components - text, checkbox, radio #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad9e954 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mperrotti
commented
Nov 16, 2021
langermank
reviewed
Nov 16, 2021
Note: I intentionally excluded this animation for the ChoiceFieldset because it has nowhere to animate in from
rezrah
reviewed
Dec 17, 2021
docs/content/ChoiceInputField.mdx
Outdated
|
|
||
| <!-- | ||
| TODO: add `validationStatus` examples when we have the validation styling done | ||
| --> |
There was a problem hiding this comment.
I guess we could get rid of it
rezrah
reviewed
Dec 17, 2021
rezrah
reviewed
Dec 17, 2021
| import {ChoiceInputField, Checkbox, Radio} from '@primer/react' | ||
| import {MarkGithubIcon} from '@primer/octicons-react' | ||
| import {ComponentChecklist} from '../src/component-checklist' | ||
| import {PropsTable} from '../src/props-table' |
There was a problem hiding this comment.
Some of these imports may not be needed anymore
There was a problem hiding this comment.
I'll see what I can get rid of. When I excluded the PropsTable import, it caused a deployment error in Vercel.
Co-authored-by: Rez <rezrah@github.com>
rezrah
reviewed
Dec 17, 2021
| ) | ||
| const results = await axe(container) | ||
| expect(results).toHaveNoViolations() | ||
| cleanup() |
There was a problem hiding this comment.
Might be worth running cleanup and jest.clearAllMocks(); on an afterEach block at the top of the test suite, as you're using spy a fair bit here
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component renders input along with its label, validation content, and hint content. It will correctly associate labels and other related content with the input.
Screenshots
Value input
Toggle (radio/checkbox) input
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
Closes Primer issue #480