Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionMenu.Overlay for ActionMenu v2 #1675

Merged
merged 5 commits into from
Dec 6, 2021
Merged

ActionMenu.Overlay for ActionMenu v2 #1675

merged 5 commits into from
Dec 6, 2021

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Dec 1, 2021 •
edited
Loading 

- <ActionMenu overlayProps={{width: 'medium', onClickOutside: handleClickOutside}}>
+ <ActionMenu>
    
    <ActionMenu.Button>Menu</ActionMenu.Button>

+   <ActionMenu.Overlay width="medium" onClickOutside={handleClickOutside}>
      <TextInput  />
      <ActionList>
        <ActionList.Item>Copy link</ActionList.Item>
        <ActionList.Item>Quote reply</ActionList.Item>
      </ActionList>
+   </ActionMenu.Overlay>
  </ActionMenu>
  • Added/updated tests - nope, going to follow up in branch/siddharth/actionmenu-tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: c8affca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 57.04 KB (-0.01% 🔽)
dist/browser.umd.js 57.4 KB (-0.03% 🔽)

@siddharthkp siddharthkp self-assigned this Dec 1, 2021
colebemis
colebemis reviewed Dec 1, 2021
View reviewed changes
src/ActionMenu2.tsx Outdated Show resolved Hide resolved
@siddharthkp siddharthkp marked this pull request as ready for review December 1, 2021 23:06
@siddharthkp siddharthkp requested review from a team and colebemis December 1, 2021 23:06
@siddharthkp siddharthkp merged commit 2380b66 into main Dec 6, 2021
@siddharthkp siddharthkp deleted the siddharthkp/actionmenu-overlay branch December 6, 2021 13:09
@github-actions github-actions bot mentioned this pull request Dec 6, 2021
Merged
pksjce pushed a commit that referenced this pull request Dec 20, 2021
@siddharthkp @pksjce
ActionMenu.Overlay for ActionMenu v2 (#1675)
349e194 
* steal props from overlay :D

* Alternate implementation with context

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@pksjce pksjce Awaiting requested review from pksjce

Assignees

@siddharthkp siddharthkp

Labels
react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siddharthkp @colebemis