NewButton -> Button2 #1730
Merged
NewButton -> Button2 #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32a4ad0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
reviewed
Dec 14, 2021
| @@ -7,5 +7,5 @@ | |||
|
|
|||
| // Components | |||
| export * from './ActionList2' | |||
| export * from './NewButton' | |||
| export * from './Button2' | |||
siddharthkp
reviewed
Dec 14, 2021
src/index.ts
Outdated
| export {NewButton} from './NewButton' | ||
| export type {NewButtonProps} from './NewButton' | ||
| export {Button2} from './Button2' | ||
| export type {Button2Props} from './Button2' |
There was a problem hiding this comment.
should we remove this from the main bundle and only ship it in drafts? based on this proposal
siddharthkp
reviewed
Dec 14, 2021
src/Button2/index.ts
Outdated
| import {ButtonProps, IconButtonProps} from './types' | ||
| // change this when moving to released state | ||
| export type {ButtonProps as Button2Props, IconButtonProps} | ||
| export const Button2 = Object.assign(Button, { |
There was a problem hiding this comment.
How do you feel about exporting this as Button instead of Button2. The scoping would happen with the import statement instead of name. See also
import {Button} from '@primer/react
and
import {Button} from '@primer/react/drafts
|
@pksjce This change should probably have a changeset since we want this PR to trigger a new release |
pksjce
force-pushed
the
pk/new-button-filenames
branch
from
2001204
to
39e4447
Compare
pksjce
force-pushed
the
pk/new-button-filenames
branch
from
3b51e92
to
c6e9419
Compare
mperrotti
approved these changes
Dec 16, 2021
Merged
pksjce
added a commit
that referenced
this pull request
Dec 20, 2021
* Rename new button stuff * Update tests * Export Button component * Change button2 storybook name * Create fuzzy-meals-explain.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No visual changes. Just filename and component name changes.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.