-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnchoredOverlay: Add aria-expanded to anchor #1758
Conversation
🦋 Changeset detectedLatest commit: f562ed9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
@@ -193,6 +194,7 @@ exports[`AnchoredOverlay should render consistently when open 1`] = ` | |||
font-family="normal" | |||
> | |||
<button | |||
aria-expanded="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wierd that this is a string though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah!
the types are accepts both, so that's nice
'aria-expanded'?: boolean | 'false' | 'true';
ref: @types/react
Updated story + docs for controlled anchor in ActionMenu2
Screenshots
Screen.Recording.2021-12-22.at.3.28.53.PM.mov
Merge checklist