Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionMenu2: Add aria-labelledby to ActionList #1759

Merged
merged 9 commits into from Jan 14, 2022
Merged

ActionMenu2: Add aria-labelledby to ActionList #1759

merged 9 commits into from Jan 14, 2022

Conversation

siddharthkp
Copy link
Contributor

@siddharthkp siddharthkp commented Dec 22, 2021 •
edited

Changes:

  • AnchoredOverlay: Add support for passing an id to the anchor
  • AnchoredOverlay: Remove unnecessary aria-labelledby on anchor (which was the same as the id on the anchor)
  • ActionMenu v2: Add aria-labelledby for ActionList

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@siddharthkp siddharthkp requested review from a team and jfuchs December 22, 2021 15:05
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2021 •
edited

🦋 Changeset detected

Latest commit: c766770

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp self-assigned this Dec 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2021 •
edited

size-limit report 📦

Path Size
dist/browser.esm.js 61.25 KB (-0.01% 🔽)
dist/browser.umd.js 61.63 KB (-0.01% 🔽)

@siddharthkp siddharthkp temporarily deployed to visual-testing January 7, 2022 10:06 Inactive
rezrah
rezrah reviewed Jan 10, 2022
View reviewed changes
docs/content/AnchoredOverlay.mdx Outdated
<PropsTableRow
name="anchorId"
type="string"
description="Optional: An override to the internal id that will be passed to the anchor."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think you'll need to add optional here, as it's assumed they are all optional unless flagged as required.

@siddharthkp siddharthkp temporarily deployed to visual-testing January 11, 2022 09:57 Inactive
@siddharthkp siddharthkp temporarily deployed to visual-testing January 11, 2022 09:57 Inactive
@siddharthkp siddharthkp temporarily deployed to visual-testing January 11, 2022 10:16 Inactive
@siddharthkp siddharthkp temporarily deployed to visual-testing January 13, 2022 14:43 Inactive
@siddharthkp siddharthkp merged commit 493c6ea into main Jan 14, 2022
@siddharthkp siddharthkp deleted the siddharth/actionmenu2-aria-labelledby branch January 14, 2022 07:42
@primer-css primer-css mentioned this pull request Jan 14, 2022
Merged
@iansan5653 iansan5653 mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezrah rezrah rezrah approved these changes

@jfuchs jfuchs Awaiting requested review from jfuchs

Assignees

@siddharthkp siddharthkp

Labels
accessibility react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siddharthkp @rezrah