Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionMenu v2: Use Button v2 as ActionMenu.Button + caret #1779

Merged
merged 4 commits into from Jan 19, 2022

Conversation

siddharthkp
Copy link
Contributor

Switched from Button v1 to Button v2 in ActionMenu

@siddharthkp siddharthkp requested review from pksjce and a team January 7, 2022 10:03
@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2022

🦋 Changeset detected

Latest commit: ecaf52f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp temporarily deployed to visual-testing January 7, 2022 10:03 Inactive
@siddharthkp siddharthkp changed the title ActionMenu v2: Use Button v2 ActionMenu v2: Use Button v2 as ActionMenu.Button Jan 7, 2022
@siddharthkp siddharthkp self-assigned this Jan 7, 2022
@siddharthkp siddharthkp temporarily deployed to visual-testing January 7, 2022 10:04 Inactive
@siddharthkp siddharthkp added docs Documentation react labels Jan 7, 2022
@siddharthkp
Copy link
Contributor Author

@pksjce Would love your feedback on docs and stories for usage of Button v2

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 61.25 KB (0%)
dist/browser.umd.js 61.63 KB (0%)

@siddharthkp siddharthkp changed the title ActionMenu v2: Use Button v2 as ActionMenu.Button ActionMenu v2: Use Button v2 as ActionMenu.Button + caret Jan 7, 2022
@siddharthkp siddharthkp merged commit 2630800 into main Jan 19, 2022
@siddharthkp siddharthkp deleted the siddharth/actionmenu2-use-button2-with-caret branch January 19, 2022 15:33
@primer-css primer-css mentioned this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants