Fix / better typing for history location #1794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously added
Location | Pathname
as a union type for theto
Prop.Turns out that
history
at v5 conveniently exports an explicitTo
that feels more relevant (and easier to reason about) for this prop, so I'm following up on the previous change by swapping out for this instead.Screenshots
Tested canary in memex ✅
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.