-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @primer/behaviors #1814
Conversation
🦋 Changeset detectedLatest commit: 335827a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with next, create-react-app and memex, works flawlessly ✅
Nitpick: the lockfileVersion of package-lock is updated in this PR, is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
FYI @pksjce I've tested in Next.js ✅ and Remix Run ❌ .. Multiple Remix error still occurring. E.g. |
@primer/behaviors has been updated to output both cjs and esm files now. This needs to be consumed in primer/react
Closes #1762
There are no visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.