Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @primer/behaviors #1814

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Upgrade @primer/behaviors #1814

merged 3 commits into from
Jan 26, 2022

Conversation

pksjce
Copy link
Collaborator

@pksjce pksjce commented Jan 21, 2022

@primer/behaviors has been updated to output both cjs and esm files now. This needs to be consumed in primer/react

Closes #1762

There are no visual changes

Merge checklist

  • Tested in nextjs project
  • Tested in remix project

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@pksjce pksjce requested review from a team and siddharthkp January 21, 2022 04:39
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2022

🦋 Changeset detected

Latest commit: 335827a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 61.28 KB (0%)
dist/browser.umd.js 61.66 KB (0%)

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with next, create-react-app and memex, works flawlessly ✅

Nitpick: the lockfileVersion of package-lock is updated in this PR, is that intentional?

Copy link
Contributor

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 :shipit:

@rezrah
Copy link
Contributor

rezrah commented Jan 24, 2022

FYI @pksjce I've tested in Next.js ✅ and Remix Run ❌ ..

Multiple Remix error still occurring. E.g. error: Could not resolve "@primer/behaviors" (mark it as external to exclude it from the bundle) and None of the conditions provided ("types", "require", "module") match any of the currently active conditions ("browser", "default", "import")... Interestingly on the latter, it looks like we may be missing some alternate import configurations. Maybe we can try setting default to point to CJS path to start with.

@rezrah rezrah merged commit 384c375 into main Jan 26, 2022
@rezrah rezrah deleted the pk/update-primer-behavior branch January 26, 2022 10:16
@primer-css primer-css mentioned this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use package with Next.js: ERR_REQUIRE_ESM
3 participants