PageLayout: Prevent content region from wrapping on wide viewports #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bbdfc2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
🚫 Looks like this broke the other stories. Investigating... |
|
Fixed with |
mperrotti
approved these changes
Feb 9, 2022
mperrotti
reviewed
Feb 9, 2022
src/PageLayout/PageLayout.tsx
Outdated
| // Set flex-basis to 0% to allow flex-grow to control the width of the content region. | ||
| // Without this, the content region could wrap onto a different line | ||
| // than the pane region on wide viewports if its contents are too wide. | ||
| flexBasis: '0%', |
There was a problem hiding this comment.
Minor nitpick: we could just say flexBasis: 0. We don't need the unit
colebemis
commented
Feb 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the contents of
PageLayout.Contentare too wide,PageLayout.Contentwraps onto a different line thanPageLayout.Pane.Solution
This PR fixes this issue with a combination of
flex-grow: 1andflex-basis: 0%to ensure thatPageLayout.Contentnever wraps on wide viewports.Screenshots
Browsers
Part of https://github.com/github/primer/issues/565