-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v35 component doc page fixes #1942
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
fdd6915
prepare integration branch
rezrah 4a0cc23
Merge branch 'main' into next/v35.0.0
siddharthkp ff7da70
Merge branch 'main' into next/v35.0.0
colebemis 94034e3
Merge branch 'main' into next/v35.0.0
rezrah 8cd1243
Move deprecated components to deprecated folder (#1881)
pksjce 310e655
Prefix component with types exported from ActionList2 and ActionMenu2…
siddharthkp df75752
Export PageLayout from main bundle (#1882)
colebemis 6fc788f
Merge branch 'main' into next/v35.0.0
colebemis 14bd580
Update release notes and add deprecation notices for SelectMenu and D…
rezrah f366604
Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2 (#1895)
siddharthkp c5c4b92
Revert "Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2 (#189…
siddharthkp 17ef5ef
Deprecate ActionList v1 & Promote drafts/ActionList v2 (#1893)
siddharthkp d402357
Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2 (#1897)
siddharthkp 09f87c5
Merge branch 'main' into next/v35.0.0
siddharthkp 87889b5
Merge branch 'main' of github.com:primer/react into next/v35.0.0
rezrah d6d1ca4
Deprecate DropdownMenu v1 + Remove DropdownMenu v2 (#1898)
siddharthkp 64b8f88
Fix code examples in changeset (#1901)
siddharthkp 05e54ca
Merge remote-tracking branch 'origin/main' into next-major
colebemis b51ea3b
Update .changeset/deprecate-actionlistv1-promote-actionlistv2.md
colebemis a8a3de1
Add linebreaks to changesets
colebemis 61404ae
Button deprecation (#1908)
pksjce f94dcd3
Deprecate components replaced by FormControl (#1888)
mperrotti 363bb07
fix merge conflicts with main
rezrah 4babf20
Revert "fix merge conflicts with main"
rezrah d61b28a
Deprecate ChoiceFieldset and ChoiceInputField (#1900)
mperrotti e9b81fa
Deprecate legacy Label component (#1889)
mperrotti 5b18a97
Move remaining deprecated components to src/deprecated (#1917)
siddharthkp 4d4163c
Various fixes for v35 (#1916)
rezrah 6cc86b2
Create changeset-for-1917.md (#1919)
siddharthkp 561aad8
Add align prop on ActionMenu.Overlay to pass through to AnchoredOverl…
siddharthkp b1d7b8c
ActionMenu.Button: Fix spacing between text and caret (#1922)
siddharthkp a88749a
Update ActionMenu docs (#1931)
siddharthkp a98091c
Button: Update active styles + use them for aria-expanded (#1915)
siddharthkp 1c38f84
merge main and resolve conflicts
rezrah 41dd547
fix broken test following main merging conflict resolution
rezrah 33da6a0
Fixes for v35 (#1934)
rezrah f235c3c
v35: Remove type aliases for ActionList (#1937)
siddharthkp 7d3021e
Next major changeset edits (#1939)
colebemis 8959aeb
Fixes for v35 (#1938)
rezrah 2868c21
Merge branch 'main' into next-major
rezrah 002e9cf
add missing fragments to changesets (#1940)
rezrah 16a5d17
Update changeset examples (#1941)
colebemis 4f07696
Fix table in changeset
colebemis 6bb44c4
Add missing comma
colebemis f69a6d0
Fix grid changeset
colebemis 8675cd8
Update button changeset
colebemis 71cdb3f
rms deprecated components and layout tweaks
mperrotti bb88426
updates snaps
mperrotti 7e43360
adds changeset
mperrotti 287cebb
Merge branch 'main' into mp/fix-v35-broken-docs
mperrotti 06a87c3
Merge branch 'main' into mp/fix-v35-broken-docs
colebemis 8deef5d
Update title and componentId of deprecated components
colebemis 130f534
Add missing component ids
colebemis c32203f
Remove link button docs
colebemis d28372f
Update dialog props
colebemis 2b1073f
Update nav.yml
colebemis d762c89
Update live code scope
colebemis 721cbb2
Merge branch 'main' into mp/fix-v35-broken-docs
mperrotti 1c9e349
Merge branch 'main' into mp/fix-v35-broken-docs
mperrotti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@primer/react': minor | ||
--- | ||
|
||
Adds button element selector to FilteredSearch button styles |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
--- | ||
componentId: border_box | ||
title: BorderBox | ||
status: Deprecated | ||
--- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
--- | ||
componentId: dropdown_menu | ||
title: DropdownMenu | ||
status: Deprecated | ||
--- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
--- | ||
componentId: flex | ||
title: Flex | ||
status: Deprecated | ||
--- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
--- | ||
componentId: form_group | ||
title: FormGroup | ||
status: Deprecated | ||
--- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
--- | ||
componentId: grid | ||
title: Grid | ||
status: Deprecated | ||
--- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
--- | ||
componentId: position | ||
title: Position | ||
status: Deprecated | ||
--- | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think using
legacy
will add to any confusion about which component we are talking about?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anything, I think it makes it clearer