Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailingAction to TextInput #1947

Merged
merged 51 commits into from
Mar 29, 2022
Merged

Add trailingAction to TextInput #1947

merged 51 commits into from
Mar 29, 2022

Conversation

mperrotti
Copy link
Contributor

Adds the capability to render a trailing action in a text input.

Closes https://github.com/github/primer/issues/748

Screenshots

Kapture 2022-03-10 at 09 36 01

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and colebemis March 10, 2022 14:44
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2022

🦋 Changeset detected

Latest commit: e73b569

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mperrotti mperrotti marked this pull request as draft March 10, 2022 14:44
@mperrotti
Copy link
Contributor Author

#1920 should merge before this

@rezrah rezrah requested a review from siddharthkp March 21, 2022 15:38
@siddharthkp siddharthkp self-assigned this Mar 21, 2022
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one tiny piece left: #1947 (comment)

@mperrotti mperrotti temporarily deployed to visual-testing March 29, 2022 15:25 Inactive
@mperrotti mperrotti merged commit edc85c9 into main Mar 29, 2022
@mperrotti mperrotti deleted the mp/text-input-trailing-action branch March 29, 2022 20:01
@primer-css primer-css mentioned this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants