Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward ref to FormControl #1949

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Forward ref to FormControl #1949

merged 3 commits into from
Mar 10, 2022

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Mar 10, 2022

We recently deprecated FormGroup in favor of FormControl. However, @dusave ran into issues migrating from FormGroup to FormControl because FormControl didn't accept a ref prop. Now it does :)

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2022

🦋 Changeset detected

Latest commit: 48d26fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 63.18 KB (-0.01% 🔽)
dist/browser.umd.js 63.53 KB (+0.02% 🔺)

Copy link
Contributor

@dusave dusave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 Thanks for the quick patch!

@colebemis colebemis merged commit e430bd8 into main Mar 10, 2022
@colebemis colebemis deleted the form-control-ref branch March 10, 2022 23:23
@primer-css primer-css mentioned this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants