Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small variant to underline nav #2225

Merged
merged 8 commits into from
Aug 25, 2022
Merged

Add small variant to underline nav #2225

merged 8 commits into from
Aug 25, 2022

Conversation

pksjce
Copy link
Collaborator

@pksjce pksjce commented Aug 11, 2022

Describe your changes here.

Changed font-size and padding values to add a small variant.

Screen.Recording.2022-08-11.at.4.41.23.pm.mov

Closes https://github.com/github/primer/issues/982

Merge checklist

  • Added/updated tests (added storybook arg)
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@pksjce pksjce requested review from a team and mperrotti August 11, 2022 06:46
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022

🦋 Changeset detected

Latest commit: cf0f980

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pksjce pksjce temporarily deployed to needs-approval August 11, 2022 06:47 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 75.63 KB (0%)
dist/browser.umd.js 76.24 KB (0%)

@pksjce pksjce temporarily deployed to github-pages August 11, 2022 06:54 Inactive
@pksjce pksjce temporarily deployed to github-pages August 11, 2022 06:56 Inactive
@pksjce pksjce temporarily deployed to github-pages August 12, 2022 12:41 Inactive
@pksjce pksjce temporarily deployed to github-pages August 12, 2022 12:43 Inactive
@pksjce pksjce temporarily deployed to github-pages August 12, 2022 13:00 Inactive
@pksjce pksjce temporarily deployed to github-pages August 12, 2022 13:01 Inactive
@pksjce pksjce temporarily deployed to github-pages August 16, 2022 03:09 Inactive
@pksjce pksjce temporarily deployed to github-pages August 16, 2022 03:11 Inactive
Copy link
Contributor

@mperrotti mperrotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should vertically center the icons in their container using something like this:

display: inline-flex;
align-items: center;

They look a little "off" now when variant === 'small' :
Kapture 2022-08-18 at 10 52 45

Everything else looks good though! 👍

@mperrotti
Copy link
Contributor

@pksjce - I pushed a commit to adjust the vertical alignment of the icons. If you don't feel like we need to pair later, you can remove the meeting from the calendar.

@mperrotti mperrotti temporarily deployed to github-pages August 24, 2022 18:57 Inactive
@pksjce
Copy link
Collaborator Author

pksjce commented Aug 25, 2022

Thanks! @mperrotti . I was trying the same at the linkStyles 🤦‍♀️ Will go ahead and merge this!

@pksjce pksjce enabled auto-merge (squash) August 25, 2022 02:55
@pksjce pksjce temporarily deployed to github-pages August 25, 2022 03:04 Inactive
@pksjce pksjce merged commit 2c9bd01 into main Aug 25, 2022
@pksjce pksjce deleted the pk/underlinenav-small branch August 25, 2022 03:04
@primer-css primer-css mentioned this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants