Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates SegmentedControl to Alpha status #2228

Merged
merged 10 commits into from
Aug 18, 2022

Conversation

mperrotti
Copy link
Contributor

No description provided.

@mperrotti mperrotti requested review from a team and siddharthkp August 12, 2022 17:40
@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2022

🦋 Changeset detected

Latest commit: c33301f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 75.76 KB (+2.02% 🔺)
dist/browser.umd.js 76.36 KB (+2.06% 🔺)

@mperrotti mperrotti temporarily deployed to github-pages August 12, 2022 17:51 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 12, 2022 17:53 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 15, 2022 15:51 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 15, 2022 15:52 Inactive
description: Use a segmented control to let users select an option from a short list and immediately apply the selection
status: Alpha
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component lifecycle label doesn't appear to be updating. Is there something else I need to do to get this showing "Alpha" instead of "Drafts"?

Screen Shot 2022-08-15 at 11 56 22 AM

Copy link
Member

@siddharthkp siddharthkp Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be related to preview deployment build because I see your changes on my machine 🤔

Copy link
Member

@siddharthkp siddharthkp Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment is fixed now, turns out it was my fault ✨ 🙃

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@siddharthkp siddharthkp temporarily deployed to github-pages August 16, 2022 09:41 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's just me again, but navigation through arrow keys introduced in #2145 doesn't work 🤔

Perfect otherwise, approving in advance.

Screen recording:

segmented-control-keyboard-interaction.mov

@mperrotti
Copy link
Contributor Author

@siddharthkp - it's working as expected. We removed that functionality in #2220

@mperrotti mperrotti temporarily deployed to github-pages August 17, 2022 15:55 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 17, 2022 23:30 Inactive
@mperrotti mperrotti temporarily deployed to github-pages August 18, 2022 18:31 Inactive
@colebemis colebemis merged commit bf99db9 into main Aug 18, 2022
@colebemis colebemis deleted the mp/segmented-conrol-draft-to-alpha branch August 18, 2022 20:44
@primer-css primer-css mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants