Implement SplitPageLayout #2239
Conversation
🦋 Changeset detectedLatest commit: 6375a93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| @@ -1,7 +1,6 @@ | |||
| import {Meta, Story} from '@storybook/react' | |||
| import React from 'react' | |||
There was a problem hiding this comment.
General feedback unrelated to this specific PR:
For some components we do examples.stories.tsx and fixtures.stories.tsx. This PR is following the file structure ADR, which advocates for one story file per component.
I'm still not totally clear on when/why to split the stories into two files. @siddharthkp - did you write docs about examples.stories.tsx and fixtures.stories.tsx? Have we silently abandoned that way of writing stories?
There was a problem hiding this comment.
Yeah, I was also curious about this
| type={`ResponsiveValue< | ||
| 'start' | 'end' | ||
| >`} | ||
| type={`| 'start' |
There was a problem hiding this comment.
Non-blocking: This is much clearer to the docs reader than ResponsiveValue<'start' | 'end'>, but it will be annoying to update when/if we change our breakpoints.
There was a problem hiding this comment.
Agreed. This is a temporary solution until we can think of a better way to document responsive values. Open to ideas!
Implements draft SplitPageLayout using PageLayout.
👉 SplitPageLayout docs
Note to reviewers: The bulk of the implementation lives in
src/SplitPageLayout/SplitPageLayout.tsxCloses https://github.com/github/primer/issues/793
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.