Fix @koddson/textarea-caret breaking non-ESM builds
#2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d9cac67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iansan5653
commented
Aug 18, 2022
Comment on lines
+58
to
+59
| * Adapted from https://github.com/koddsson/textarea-caret-position, which was itself | ||
| * forked from https://github.com/component/textarea-caret-position. |
There was a problem hiding this comment.
I'm no expert on licensing. Both source projects are MIT-licensed - is this sufficient attribution? Do we also need to pull in the copyright statements from those licenses?
size-limit report 📦
|
colebemis
approved these changes
Aug 18, 2022
Comment on lines
+58
to
+59
| * Adapted from https://github.com/koddsson/textarea-caret-position, which was itself | ||
| * forked from https://github.com/component/textarea-caret-position. |
…only-module-textarea-caret-breaking-nextjs
…only-module-textarea-caret-breaking-nextjs
colebemis
deleted the
2238-regression-inlineautocomplete-uses-esm-only-module-textarea-caret-breaking-nextjs
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2238 breaking non-ESM builds by inlining the entire module. This also allows us to inline the bug fixes / workaround hacks that we were originally calling after importing. In addition, it allows us to inline the types instead of defining a
.d.tsfile.I have tested this in Storybook and backported the change to Memex to test there as well.
Merge checklist