-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ThemeProvider): add dark, light alias for ThemeProvider #2259
Conversation
🦋 Changeset detectedLatest commit: c07ffb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be convenient for product teams. Thanks, @joshblack!
Maybe copy and paste these test cases and replace https://github.com/primer/react/blob/main/src/__tests__/ThemeProvider.test.tsx#L119-L137 |
@colebemis love it, done! |
Closes https://github.com/github/primer/issues/919
Update
ThemeProvider
'sColorMode
to acceptdark
andlight
as aliases fornight
andday
. Let me know if I missed any branches here that could be seeingdark
orlight
ascolorMode
, was trying to following along in the source code but could easily have missed a path 👀Question for reviewers
What would be the best way to test this in
ThemeProvider.test.tsx
? 👀