Deploy Node app to Now #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
shawnbot
commented
Aug 22, 2018
| "files": [ | ||
| "examples", | ||
| "rollup.config.js", | ||
| "src" |
There was a problem hiding this comment.
I honestly don't know why these files needed to be explicitly whitelisted, but Now doesn't seem to want to copy them by default.
shawnbot
commented
Aug 22, 2018
| "public": "docs", | ||
| "rewrites": [ | ||
| {"source": "/components/*", "destination": "/index.html"}, | ||
| {"source": "/demos/*", "destination": "/index.html"} |
There was a problem hiding this comment.
These redirects make the component and demo subpages work dynamically.
This was referenced Aug 22, 2018
jonrohan
approved these changes
Aug 22, 2018
emplums
reviewed
Aug 23, 2018
| <meta name='og:title' content='Primer React'> | ||
| <meta name='description' content='Primer components built with React.js.'> | ||
| <link rel='icon' href='https://primer.github.io/favicon.png'> | ||
| <link rel='stylesheet' href='${basename}/dist/css/build.css'> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #221 and configures the app to deploy with Node app rather than statically.
TODO
"type": "static"fromnow.jsonbuild:docsnpm run-script tobuildso that Now will build docs on deploymentserveand use it to serve the builtdocsfolderdocsdirectory from git, and add it to.gitignore