-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug in the useMnemonics hook to make it compatible with textareas #2317
Conversation
🦋 Changeset detectedLatest commit: 304846b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as a reviewer from the Pull Requests' React team who is using this component.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good for useMnemonics!
However, I don't this is useful for your use case, 😅 left a comment on https://github.com/github/pull-requests/issues/5499#issuecomment-1243542876
Looks CI is failing (linting), we're good to go after that's fixed |
👋 Hi! Just checking, is this still useful? |
Fix a bug in the useMnemonics hook that makes it incompatible with
textarea
elements. This bug manifested itself when I was trying to use aMarkdownEditor
in anActionMenu
.Closes #2316
Screenshots
No visual changes.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.