feat(PageLayout): support a ref on PageLayout.Pane #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0474b7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Looks great. Thanks, @joshblack!
Can you update the prop documentation table for PageLayout.Pane to include this ref prop?
We have a utility component to make this easy:
<PropsTableRefRow
elementType="div"
refType="HTMLDivElement"
/>
|
Thanks @colebemis! And of course, done ✨ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference https://github.com/github/primer/issues/1284
This PR updates
PageLayout.Paneto useReact.forwardRefand places theforwardRefon theBoxwrappingchildrenLet me know if I'm interpreting the right element from #1284, I assumed it was the
Boxsurrounding thechildrenof the component 👀 I also tried to type theReact.forwardRefcorrectly but would love a second look at that to see if I got the type correct.