-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(build): update to use rollup #2327
Conversation
🦋 Changeset detectedLatest commit: 10b6db0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a great incremental step towards fixing our bundle issues. Great work, @joshblack!
This is a follow-up to #2257 after #2314 landed to remove circular imports.
This PR specifically removes the
compile
step inscripts/build
in favor of using Rollup. It uses the existing rollup setup (specifically with babel) with the potential to move towards another plugin (like@rollup/plugin-typescript
) in the future in order to further consolidate the build step (like generating declaration files)I tried my best to verify all the support export paths/patterns but would love a second look at these to see if I missed any!
@primer/react
./lib/index.js
@primer/react
./lib-esm/index.js
@primer/react/drafts
./lib/drafts/index.js
@primer/react/drafts
./lib-esm/drafts/index.js
@primer/react/deprecated
./lib/deprecated/index.js
@primer/react/deprecated
./lib-esm/deprecated/index.js