Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(SelectPanel): update docs with keyboard interactions #2335

Merged
merged 10 commits into from
Oct 10, 2022

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 14, 2022

This PR updates the docs for SelectPanel to document the keyboard behaviors supported by the component. It also adds in an initial Status section and initial Props.

Questions

  • Is the interaction guidance here appropriate? I wasn't sure if keyboard interaction docs should live here or somewhere else 👀
  • What's the best way to write out the props for SelectPanel using the existing MDX components?
  • Is the ComponentChecklist correct?

References

@joshblack joshblack requested review from a team and rezrah September 14, 2022 16:50
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

⚠️ No Changeset found

Latest commit: d3a7a13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Sep 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 77.21 KB (0%)
dist/browser.umd.js 77.85 KB (0%)

@joshblack joshblack temporarily deployed to github-pages September 14, 2022 16:58 Inactive
docs/content/SelectPanel.mdx Outdated Show resolved Hide resolved
docs/content/SelectPanel.mdx Outdated Show resolved Hide resolved
docs/content/SelectPanel.mdx Show resolved Hide resolved
docs/content/SelectPanel.mdx Outdated Show resolved Hide resolved
docs/content/SelectPanel.mdx Outdated Show resolved Hide resolved
docs/content/SelectPanel.mdx Show resolved Hide resolved
joshblack and others added 5 commits September 16, 2022 11:21
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
@joshblack joshblack temporarily deployed to github-pages September 16, 2022 16:28 Inactive
@joshblack joshblack temporarily deployed to github-pages October 10, 2022 16:19 Inactive
@joshblack joshblack temporarily deployed to github-pages October 10, 2022 16:43 Inactive
@joshblack joshblack temporarily deployed to github-pages October 10, 2022 17:02 Inactive
@joshblack joshblack merged commit fa6ac62 into main Oct 10, 2022
@joshblack joshblack deleted the docs/add-keyboard-behavior-to-select-panel branch October 10, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants