Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prop to control URL pasting behavior in MarkdownEditor #2368

Merged

Conversation

iansan5653
Copy link
Contributor

@iansan5653 iansan5653 commented Sep 23, 2022

Adds a new prop pasteUrlsAsPlainText to the MarkdownEditor component. When true, URLs will replace selected text instead of auto-creating a link. The prop defaults to false so this is not a breaking change.

Fixes #2363. For more context, please see that issue.

Merge checklist

  • Added/updated tests
  • [ ] Added/updated documentation (MarkdownEditor props are not documented outside of code yet)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@iansan5653 iansan5653 requested review from a team and mperrotti September 23, 2022 17:10
@iansan5653 iansan5653 linked an issue Sep 23, 2022 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022

🦋 Changeset detected

Latest commit: f586ac3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 77.08 KB (0%)
dist/browser.umd.js 77.68 KB (0%)

@iansan5653 iansan5653 temporarily deployed to github-pages September 23, 2022 17:18 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iansan5653 iansan5653 merged commit aeb6152 into main Sep 23, 2022
@iansan5653 iansan5653 deleted the 2363-add-a-prop-to-disable-link-pasting-in-markdowneditor branch September 23, 2022 18:06
@primer-css primer-css mentioned this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a prop to disable link pasting in MarkdownEditor
3 participants